Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Upgrade puppeteer to latest (10.0.0) #683

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

gravi2
Copy link
Contributor

@gravi2 gravi2 commented May 6, 2021

This PR upgrades puppeteer to latest (10.0.0) version. As part of the fix following things were done:

  1. Fixed renderer.ts for using puppeteer.HTTPRequest and puppeteer.HTTPResponse.
  2. replaced deprecated page.addListener() with page.on()
  3. tsconfig.json will now use skipLibCheck to avoid 'tsc' trying to pick/work on files in node_modules directory.

2. Fixed renderer.ts for puppeteer changes.
3. replaced deprecated page.addListener with page.on
@gravi2 gravi2 requested a review from AVGP as a code owner May 6, 2021 07:25
@gravi2
Copy link
Contributor Author

gravi2 commented May 6, 2021

@AVGP Hopefully this PR meets your expectation for puppeteer upgrade. If I missed something, please do let me know. FYI, the ec2 CI checks seem to be failing on all the PRs. See the issue #683 that I logged today.
Note: This PR addresses the failures that deependabot #681 has.

@gravi2 gravi2 changed the title Upgrade puppeteer to latest (9.1.1) Upgrade puppeteer to latest (10.0.0) Jun 4, 2021
@gravi2
Copy link
Contributor Author

gravi2 commented Jun 4, 2021

@AVGP Puppeteer 10.0.0 was released few days back. I have changed this PR to now include the latest puppeteer (i.e 10.0.0).

@AVGP
Copy link
Collaborator

AVGP commented Jul 10, 2021

Thanks for the pull request! This is a great improvement and I will make a release accordingly to 3.1.1

@AVGP AVGP merged commit 7999fc5 into GoogleChrome:main Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants